flashing leak

If it was in fact the flashing that caused the leak and it was fixed then there is no need to worry.

everyone is telling us it is the flashing and caulking will fix it. Is that a long term repair or something just to get through the closing?

The answer you wont like is unfortunately the only answer, every leak is unique.
And sometimes fixing one place can cause the next weakest point to leak.
Just fix them early and be observant but you shouldnt be losing sleep over it.

Water combine with gravity finds the path of least resistance. You want to maintain the outside routes so it doesn't find inside routes.

thanks everyone. And I'll really only know the answer when it rains hard enough to cause a leak. But I feel confident about having it repaired and proceeding with the transaction.

When you strain, a little pee pee comes out? See a urologist. Ask for dr Olsen the one legged wonder at columbia. Say w67 sent ya.